New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow *LICENSE file names #14

Merged
merged 1 commit into from Jul 22, 2014

Conversation

Projects
None yet
3 participants
@sunny
Contributor

sunny commented Jul 21, 2014

Allow LICENSE file to start with license name, e.g. MIT-LICENSE (Rails engines default).

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 21, 2014

Coverage Status

Coverage remained the same when pulling 75894ce on sunny:patch-1 into 5bae628 on rafalchmiel:master.

coveralls commented Jul 21, 2014

Coverage Status

Coverage remained the same when pulling 75894ce on sunny:patch-1 into 5bae628 on rafalchmiel:master.

@rafalchmiel

This comment has been minimized.

Show comment
Hide comment
@rafalchmiel

rafalchmiel Jul 21, 2014

Owner

Agreed. Looks good. Could you add a spec for this as well? Thanks!

Owner

rafalchmiel commented Jul 21, 2014

Agreed. Looks good. Could you add a spec for this as well? Thanks!

Allow *LICENSE file names
Allow LICENSE file to start with license name, e.g. MIT-LICENSE (Rails engines default).
@sunny

This comment has been minimized.

Show comment
Hide comment
@sunny

sunny Jul 22, 2014

Contributor

Sure thing! I've rebased it into one commit.

I also added a test for LICENSE* filenames.

Contributor

sunny commented Jul 22, 2014

Sure thing! I've rebased it into one commit.

I also added a test for LICENSE* filenames.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 22, 2014

Coverage Status

Coverage remained the same when pulling d5511a0 on sunny:patch-1 into 5bae628 on rafalchmiel:master.

coveralls commented Jul 22, 2014

Coverage Status

Coverage remained the same when pulling d5511a0 on sunny:patch-1 into 5bae628 on rafalchmiel:master.

rafalchmiel pushed a commit that referenced this pull request Jul 22, 2014

Rafal Chmiel
Merge pull request #14 from sunny/patch-1
Allow *LICENSE file names

@rafalchmiel rafalchmiel merged commit df6e70d into rafalchmiel:master Jul 22, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@rafalchmiel

This comment has been minimized.

Show comment
Hide comment
@rafalchmiel

rafalchmiel Jul 22, 2014

Owner

Ahh, thanks a lot!

Owner

rafalchmiel commented Jul 22, 2014

Ahh, thanks a lot!

@rafalchmiel rafalchmiel added the feature label Jul 22, 2014

@sunny sunny deleted the sunny:patch-1 branch Sep 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment