New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-81687 #881

Closed
wants to merge 145 commits into
base: master
from

Conversation

Projects
None yet
@brianchandotcom

brianchandotcom commented Oct 1, 2018

No description provided.

jkappler and others added some commits Oct 1, 2018

LPS-85736 Just like in friendly URL service, we have to decode the ur…
…lTitle first since it's encoded, and then normalize it to match what we have in the DB
LPS-85731 Adds missing checkbox to vertical card on multiple selectio…
…n. Also, since the markup is different, check also for li element, and not only tr element if not found
@liferay-continuous-integration

This comment has been minimized.

Collaborator

liferay-continuous-integration commented Oct 1, 2018

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@brianchandotcom

This comment has been minimized.

brianchandotcom commented Oct 1, 2018

@rafaprax

This comment has been minimized.

Owner

rafaprax commented Oct 1, 2018

Just started reviewing :)

:octocat: Sent from GH.

@rafaprax

This comment has been minimized.

Owner

rafaprax commented Oct 2, 2018

Pull request submitted to brianchandotcom#63701. See changes here.

:octocat: Sent from GH.

@rafaprax rafaprax closed this Oct 2, 2018

@rafaprax

This comment has been minimized.

Owner

rafaprax commented Oct 2, 2018

Pull request submitted to brianchandotcom#63702. See changes here.

:octocat: Sent from GH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment