Skip to content

Conversation

@rafaqz
Copy link
Owner

@rafaqz rafaqz commented Aug 27, 2020

Adds a set method to set most fields in the object or dimension and rebuild the whole immutable object around that.

A fun outcome of DimensionalData being so heavily typed is you don't have to specify which field to set, you just pass in the tuple to set, the dims the are on and they will be set.

A = set(A, (Intervals(), Points()))
# or 
A = set(A, (X=>Intervals(), Y=>Points()))
# or
A = set(A, (X(Intervals()), Y(Points()))
# or
A = set(A, X=Intervals(), Y=Points())

Will set the the sampling mode to Intervals on X, Points on Y.

@rafaqz rafaqz force-pushed the set branch 2 times, most recently from 78e8894 to a8ea76c Compare August 27, 2020 05:44
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020

Codecov Report

Merging #157 into master will decrease coverage by 1.19%.
The diff coverage is 81.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   85.25%   84.05%   -1.20%     
==========================================
  Files          14       16       +2     
  Lines        1207     1286      +79     
==========================================
+ Hits         1029     1081      +52     
- Misses        178      205      +27     
Impacted Files Coverage Δ
src/DimensionalData.jl 100.00% <ø> (ø)
src/dimension.jl 87.85% <71.42%> (-3.74%) ⬇️
src/identify.jl 74.35% <74.35%> (ø)
src/array.jl 79.45% <75.00%> (-2.37%) ⬇️
src/interface.jl 92.30% <75.00%> (+3.41%) ⬆️
src/set.jl 76.78% <76.78%> (ø)
src/mode.jl 83.19% <78.12%> (-2.13%) ⬇️
src/utils.jl 90.32% <85.71%> (-0.31%) ⬇️
src/methods.jl 86.86% <91.66%> (-0.37%) ⬇️
src/selector.jl 95.32% <93.33%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab9cc2...553b319. Read the comment docs.

@rafaqz
Copy link
Owner Author

rafaqz commented Oct 3, 2020

Closed by #173

@rafaqz rafaqz closed this Oct 3, 2020
@rafaqz rafaqz deleted the set branch October 12, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants