show how to use without weaver.ini #3

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

It took me some time to find out how to use this module without having a weaver.ini. Please don't let others waste the time for searching again!

show how to use without weaver.ini
It took me some time to find out how to use this module without having a weaver.ini. Please don't let others waste the time for searching again!
Collaborator

sergeyromanov commented Aug 22, 2013

Thanks for the patch!

I'm a bit hesitant on merging it though, here's why: if I try to use the plugin the way you introduced, then Pod::Weaver's default behavior (which is to use @Default bundle) will be overloaded. Which means that we will end up with Pod like

=pod

=encoding utf-8

=cut

and that's it! And I believe this is rarely a desired behavior when using Pod::Weaver. This is true even if we have weaver.ini in place with all other specs we want. So basically, it would be ok, if we could do something like this:

[PodWeaver]
config_plugin = -Encoding 
config_plugin = @Default

But after playing with Pod::Weaver for a while I didn't manage to combine those two just by editing dist.ini.

I would really like to be pointed out that I'm missing some simple solution here, so I'm leaving this open for now.

Hi, I've commented your pull request to this module.

It would be great, if you could look into it

@nichtich nichtich referenced this pull request in rjbs/Dist-Zilla-Plugin-PodWeaver Oct 21, 2013

Closed

make config_plugin repeatable #3

Looks like this is a limitation of Dist::Zilla::Plugin::PodWeaver. I created a feature request.

this works:

in dist.ini:

[PodWeaver]

weaver.ini:

[-Encoding]
[@Default]

This should work the same

in dist.ini:

[PodWeaver]
config_plugin = -Encoding 
config_plugin = @Default

no weaver.ini

Collaborator

sergeyromanov commented Nov 23, 2013

Yes, what you told is exactly my point! Thanks for raising a new issue.

As for this particular module (Pod::Weaver::Plugin::Encoding) - I'm a planning to add a deprecation note to it as soon as I finish my quest:

http://questhub.io/realm/perl/quest/5277f3cc9f567ad56f0000e7

See also Rik's post for more details

/cc @rafl

Collaborator

sergeyromanov commented Jun 20, 2014

I'm closing this one, because upstream is fixed and [-Encoding] itself is no longer relevant with [-SingleEncoding] in Pod::Weaver's core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment