James Tucker raggi

Organizations

Official Rack repositories Wildfire, by Google Rubinius RDBI RDoc postrank-labs Google polymer Google Cloud Platform
raggi commented on pull request reinh/statsd#56
James Tucker

@zanker I was mostly just hoping for a code review, but none presented.

raggi commented on pull request eventmachine/eventmachine#420
James Tucker

I proposed EM.crank() for single-step EM a long time ago (useful for tests, as you can also then do crank_until(timeout), etc). @tmm1 didn't like it.

James Tucker
raggi merged pull request eventmachine/eventmachine#420
James Tucker
Add support for EM.set_simultaneous_accept_count(<int>).
1 commit with 55 additions and 2 deletions
raggi commented on pull request square/okhttp#1364
James Tucker

Addressed comments, PTAL - thank you!

James Tucker
  • James Tucker fee2720
    ConnectionSpec: Allow custom specifications
raggi commented on pull request square/okhttp#1364
James Tucker

Ah well. Clone done.

James Tucker
  • James Tucker b09c952
    ConnectionSpec: Allow custom specifications
raggi commented on pull request square/okhttp#1364
James Tucker

Given the varargs, I'm not sure the clone() is necessary, but my Java is still rusty.

raggi commented on pull request square/okhttp#1364
James Tucker

So supportedSpec can call cipherSuites with null, which is where this needs to be covered. It wasn't a problem for the String[] API, but varargs bo…

James Tucker
  • James Tucker a633841
    ConnectionSpec: Allow custom specifications
raggi commented on pull request square/okhttp#1364
James Tucker

I think that actually gets autoboxed. I'll track down which test does this.

James Tucker
James Tucker
Merge evma_httpserver with chunked encoding support
3 commits with 1 addition and 0 deletions
raggi commented on pull request square/okhttp#1364
James Tucker

Ok, a few changes for your review. I have done the following: The introduced public Builder constructor now no longer accepts arguments. It defaul…

James Tucker
  • James Tucker c45f1f9
    ConnectionSpec: Allow custom specifications
James Tucker
  • James Tucker 3cc09b5
    ConnectionSpec: Allow custom specifications
raggi commented on pull request square/okhttp#1364
James Tucker

varargs are mutable?

raggi commented on pull request square/okhttp#1364
James Tucker

Right, I'm just wondering if one wanted to use, say, CHACHA20, that's currently unavailable. The string API enables this. My proposal is that we'd …

James Tucker
  • James Tucker 0d88a0f
    ConnectionSpec: Allow custom specifications
raggi commented on pull request square/okhttp#1364
James Tucker

I will do so, and fix the args issue you mentioned above. Thanks!

raggi commented on pull request square/okhttp#1364
James Tucker

Hmm, and it passed I thought!

raggi commented on pull request square/okhttp#1364
James Tucker

I'm happy either way, the most important thing is being able to do this. Would you prefer varargs for a public API?

raggi commented on pull request square/okhttp#1364
James Tucker

Good question. I'd be happy with a zero-arg constructor that defaults to true. It seems that there's no use for the builder in the cleartext case t…

raggi opened pull request square/okhttp#1364
James Tucker
ConnectionSpec: Allow custom specifications
1 commit with 13 additions and 3 deletions
raggi commented on pull request rack/rack-contrib#78
James Tucker

Taking the last IP address in X-Forwarded-For after filtering known/trusted proxies is the only way to get a IP address that is trustworthy and not…

raggi merged pull request rubygems/rubygems-mirror#30
James Tucker
rescue the http fetch so timeouts do not abort everything prematurely
2 commits with 9 additions and 2 deletions
James Tucker