Skip to content

James Tucker
raggi

Organizations

@rack @rubinius @RDBI @rdoc @postrank-labs @google @Polymer @GoogleCloudPlatform
raggi commented on pull request rack/rack#1001
@raggi

Rack shouldn't have globals. A configuration middleware doesn't need to be some kind of class indirection, it just needs to add stuff to env: use ->(…

raggi starred nlf/dlite
raggi commented on pull request rack/rack#1001
@raggi

So it is safe to add new objects to env, and it makes sense in the spec today. I would drop a rails.config into the env hash for this. Similarly I'…

raggi commented on pull request GoogleCloudPlatform/php-docker#48
@raggi

That's fair, although I'm not sure if it's worse to have the extension cause an error or to have it silently fall back to files mode. Keep them spl…

raggi commented on pull request GoogleCloudPlatform/php-docker#48
@raggi

Couple of minors :+1:

raggi commented on pull request GoogleCloudPlatform/php-docker#48
@raggi

I would write this: if [[ -n "${MEMCACHE_PORT_11211_TCP_ADDR}${MEMCACHE_PORT_11211_TCP_PORT}" ]]; then

raggi commented on pull request GoogleCloudPlatform/php-docker#48
@raggi

add a -p flag, just to save any issues

raggi commented on pull request GoogleCloudPlatform/php-docker#48
@raggi

Great, thanks, yes, lets absolutely make this work for multinode configurations by default.

raggi commented on pull request GoogleCloudPlatform/php-docker#48
@raggi

Other than the discussion above, the code looks fine. Am I correct in assuming that the current default session storage behavior is files, and that…

raggi commented on pull request GoogleCloudPlatform/php-docker#48
@raggi

I would actually strongly vote in the other direction, and go for convention over configuration. Users should be able to get more things going with…

raggi commented on pull request rack/rack#1001
@raggi

Why not put it in the env, like rack.trusted_proxies, then middleware in rails could set that fetching the canonical value from config as you desire.…

@raggi
@raggi
Use HTTP 1.1 to connect to the application servers
1 commit with 2 additions and 0 deletions
@raggi

@JustinBeckwith can you give me commit / add me to the relevant teams too :pray:

@raggi
Use HTTP 1.1 to connect to the application servers
1 commit with 2 additions and 0 deletions
raggi commented on pull request rack/rack#953
@raggi

I have had to squash patches for this so many times. We need to add a doc comment. This breaks reloader use cases, and it works this way by design. t…

raggi commented on pull request rack/rack#1007
@raggi

So we reduce the size of the image, but increase the size of the repo by the new file size. What's the purpose of this change?

raggi commented on issue rack/rack#905
@raggi

@tenderlove can answer

raggi commented on issue ianr0bkny/go-sonos#2
@raggi

Is there any reason not to support a global listener? I'd be fine with this for my use case.

@raggi

Thanks Danny :)

@raggi

See https://botbot.me/freenode/appengine/2016-01-23/?tz=America/Los_Angeles They wanted to run a quick one-off standalone process to query some dat…

raggi commented on pull request rack/rack#1003
@raggi

@milkcocoa i don't do releases anymore, you'll have to beg @tenderlove

raggi pushed to master at rack/rack
@raggi
raggi merged pull request rack/rack#1003
@raggi
Strip quotes from around multipart encodings
1 commit with 19 additions and 0 deletions
raggi closed issue rack/rack#905
@raggi
Error uploading binary files in Rails 4.2, Ruby 2.1.2
raggi commented on pull request rack/rack#1003
@raggi

It was mostly to let you know that it was here, feel free to merge. There's also been enough changes in places that I'm going to ask for more eyes …

Something went wrong with that request. Please try again.