From 54351f8c3a4c7bd97b0c79b01e9214bb1614df93 Mon Sep 17 00:00:00 2001 From: Spencer Schrock Date: Mon, 23 Jan 2023 11:53:23 -0800 Subject: [PATCH] Revert "perf.: run integration tests only on approved PRs (#2609)" (#2612) This reverts commit a29182d3f2c436799d6d386b21b8d0319c574362. Signed-off-by: Spencer Schrock Signed-off-by: Spencer Schrock --- .github/workflows/integration.yml | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index b979551c66c4..3afe9888d99f 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -14,9 +14,7 @@ # Run secret-dependent integration tests only after approval name: Integration tests -on: - pull_request_review: - types: [submitted] +on: pull_request_target permissions: contents: read @@ -24,7 +22,6 @@ permissions: jobs: approve: - if: github.event.review.state == 'approved' runs-on: ubuntu-latest steps: - name: Harden Runner @@ -53,14 +50,14 @@ jobs: - name: setup-go uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # v2.2.0 with: - go-version: "1.19" + go-version: '1.19' check-latest: true - name: Prepare test env run: | - go mod download + go mod download - - name: Run GITHUB_TOKEN E2E #using retry because the GitHub token is being throttled. + - name: Run GITHUB_TOKEN E2E #using retry because the GitHub token is being throttled. uses: nick-invision/retry@943e742917ac94714d2f408a0e8320f2d1fcafcd env: GITHUB_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -71,7 +68,7 @@ jobs: timeout_minutes: 30 command: make e2e-gh-token - - name: Run PAT E2E #using retry because the GitHub token is being throttled. + - name: Run PAT E2E #using retry because the GitHub token is being throttled. uses: nick-invision/retry@943e742917ac94714d2f408a0e8320f2d1fcafcd env: GITHUB_AUTH_TOKEN: ${{ secrets.GH_AUTH_TOKEN }} @@ -84,15 +81,15 @@ jobs: - name: codecov uses: codecov/codecov-action@81cd2dc8148241f03f5839d295e000b8f761e378 # 2.1.0 with: - files: ./e2e-coverage.out - verbose: true + files: ./e2e-coverage.out + verbose: true - name: find comment uses: peter-evans/find-comment@f4499a714d59013c74a08789b48abe4b704364a0 # v2.1.0 id: fc with: issue-number: ${{ github.event.pull_request.number || github.event.client_payload.pull_request.number }} - comment-author: "github-actions[bot]" + comment-author: 'github-actions[bot]' body-includes: Integration tests ran for - name: create or update comment