Fix #2

Only run the function for newly added nodes, not the entire <body> again and again
rahulkapoor90 · ccf9d4b13324aa1273b889c631d9c757ff266f6e · ngyikp committed Feb 4, 2017 · Feb 4, 2017 · ccf9d4b
1 parent d4d6534
commit ccf9d4b13324aa1273b889c631d9c757ff266f6e
Unified Split

Showing with 9 additions and 5 deletions.

+9 −5 facebook.js
diff --git a/facebook.js b/facebook.js
@@ -8,9 +8,9 @@ _gaq.push(['_trackPageview']);
   var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
 })();
 
-const facebook_clickbait = function() {
+const facebook_clickbait = function(node) {
 
-  const images = [...document.getElementsByClassName('mbs _6m6 _2cnj _5s6c')];
+  const images = [...node.getElementsByClassName('mbs _6m6 _2cnj _5s6c')];
 
   images.forEach(function(el) {
     var links = el.getElementsByTagName('a');
@@ -47,12 +47,16 @@ var request = new XMLHttpRequest();
 
 const observer = new MutationObserver(function(mutations) {
     mutations.forEach(function(mutation) {
-        facebook_clickbait();
+        mutation.addedNodes.forEach(function(node) {
+            if (node.nodeType === 1) { // ELEMENT_NODE
+                facebook_clickbait(node);
+            }
+        });
     });
 });
 
-const config = { attributes: true, childList: true, characterData: false }
+const config = { attributes: false, childList: true, characterData: false, subtree: true }
 
 observer.observe(document.body, config);
 
-facebook_clickbait();
+facebook_clickbait(document.body);