Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp - adapt channel settling to new contracts for Arbitrum #3053

Closed
weilbith opened this issue Feb 16, 2022 · 1 comment
Closed

dApp - adapt channel settling to new contracts for Arbitrum #3053

weilbith opened this issue Feb 16, 2022 · 1 comment
Assignees

Comments

@weilbith
Copy link
Contributor

Description

There are two changes by the contracts for Arbitrum in regards of the settle timeout

  • the property has moved from individual channels to the token network
  • the value meaning has changed from block numbers to time in seconds

In result this affects the dApp in the following way:

  • the SDK does no more accept an individual settle timeout configuration value for new channels
  • the channel structure of the SDK does not include the settle timeout field anymore
  • the settle button of a closed channel has a countdown until it becomes settleable that needs to be adapted

Acceptance criteria

Tasks

  • [ ]
@weilbith weilbith self-assigned this Feb 16, 2022
@weilbith
Copy link
Contributor Author

To keep it simple and cut the time down, we have decided to remove the settleable countdown. The settle button just remains disabled until the channel becomes settleable. This is also how it was in the past. Maintaining the counter comes with a lot of challenges visually and technically. In future we might wanna tackle this "problem" again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant