Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CONTRACT_DEPLOYER_ADDRESS #1183

Closed
pirapira opened this issue Aug 19, 2019 · 0 comments · Fixed by #1322
Closed

Rename CONTRACT_DEPLOYER_ADDRESS #1183

pirapira opened this issue Aug 19, 2019 · 0 comments · Fixed by #1322
Assignees
@pirapira
Labels
efforts: low_hanging_fruit good first issue Good for newcomers P4: good_to_have

Comments

@pirapira
Copy link
Contributor

because all other constants CONTRACT_* are names of smart contracts.
@pirapira pirapira self-assigned this Oct 25, 2019
pirapira added a commit to pirapira/raiden-contracts that referenced this issue Oct 25, 2019
@pirapira
CONTRACT_DEPLOYER_ADDRESS into DEPLOYER_ADDRESS
a928e02 
because CONTRACT_* are usually names of contracts.

This fixes raiden-network#1183
@pirapira pirapira mentioned this issue Oct 25, 2019
Merged
1 task
palango pushed a commit that referenced this issue Nov 6, 2019
@pirapira @palango
CONTRACT_DEPLOYER_ADDRESS into DEPLOYER_ADDRESS
e6f01c7 
because CONTRACT_* are usually names of contracts.

This fixes #1183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pirapira pirapira

Labels
efforts: low_hanging_fruit good first issue Good for newcomers P4: good_to_have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CONTRACT_DEPLOYER_ADDRESS into DEPLOYER_ADDRESS pirapira/raiden-contracts
1 participant
@pirapira