Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy raiden fails on --contracts-version [latest] #1312

Closed
pirapira opened this issue Oct 23, 2019 · 6 comments · Fixed by #1313
Assignees
Labels

Comments

@pirapira
Copy link
Collaborator

@pirapira pirapira commented Oct 23, 2019

When I tried to follow the private net tutorial, I saw

$ python -m raiden_contracts.deploy raiden --rpc-provider $PROVIDER --private-key $PRIV_KEY --gas-price 10 --gas-limit 6000000 --contracts-version $VERSION --max-token-networks $MAX_UINT256
<snip>
raiden_contracts.contract_source_manager.ContractSourceManagerVerificationError: checksum of OneToN.sol does not match 74e024e64438d1f39f2aba4bbb7c4062bcc698bf19504eb5dd9ad45628401cb6 != 0a70253a541291f2b8d043cb5fb459d509912e3d62e8a636c81d6b7b1f9060ad
@pirapira

This comment has been minimized.

Copy link
Collaborator Author

@pirapira pirapira commented Oct 23, 2019

The way to reproduce this:

python -m raiden_contracts.deploy raiden --rpc-provider $PROVIDER --private-key $PRIV_KEY --gas-price 10 --gas-limit 6000000 --contracts-version "0.25.1" --max-token-networks $MAX_UINT256
@pirapira

This comment has been minimized.

Copy link
Collaborator Author

@pirapira pirapira commented Oct 23, 2019

Does the same problem happen on raiden-contracts:master?

@pirapira

This comment was marked as outdated.

Copy link
Collaborator Author

@pirapira pirapira commented Oct 23, 2019

No, the problem does not happen on raiden-contracts:master.

@pirapira

This comment has been minimized.

Copy link
Collaborator Author

@pirapira pirapira commented Oct 23, 2019

The problem happens when I specify the newest contracts_version.

@pirapira

This comment has been minimized.

Copy link
Collaborator Author

@pirapira pirapira commented Oct 23, 2019

I think these line are wrong:

        if self.contracts_version in [None, CONTRACTS_VERSION]:
            contract_manager_source = ContractSourceManager(contracts_source_path())
            contract_manager_source.verify_precompiled_checksums(self.precompiled_path)

When contracts_version is CONTRACTS_VERSION, the check must be against the source of CONTRACTS_VERSION instead of None.

@pirapira pirapira added the bug label Oct 23, 2019
@pirapira

This comment has been minimized.

Copy link
Collaborator Author

@pirapira pirapira commented Oct 23, 2019

This bug was not found so far because all releases had identical data and data_CONTRACTS_VERSION. Only in the newest release I cut corners and some manual surgery in data_CONTRACTS_VERSION so this bug surfaced.

@pirapira pirapira added the P1 label Oct 23, 2019
@pirapira pirapira changed the title data_0.25.1 is somehow out of sync deploy raiden fails on --contracts-version [latest] Oct 23, 2019
pirapira added a commit to pirapira/raiden-contracts that referenced this issue Oct 23, 2019
when contracts of version CONTRACTS_VERSION is deployed,
the bytecode was checked against the source of version None.

Instead, the source of CONTRACTS_VERSION must be used.

This fixes raiden-network#1312.
@pirapira pirapira self-assigned this Oct 23, 2019
pirapira added a commit that referenced this issue Oct 23, 2019
when contracts of version CONTRACTS_VERSION is deployed,
the bytecode was checked against the source of version None.

Instead, the source of CONTRACTS_VERSION must be used.

This fixes #1312.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.