Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Deposit Contract - allow to configure withdraw timeout #1612

Closed
weilbith opened this issue Mar 3, 2022 · 0 comments
Closed

User Deposit Contract - allow to configure withdraw timeout #1612

weilbith opened this issue Mar 3, 2022 · 0 comments
Assignees

Comments

@weilbith
Copy link
Contributor

weilbith commented Mar 3, 2022

As the timeout value has changed from block numbers to time in seconds, this has become a challenge for (end-to-end) tests. The current constant value are 25min. That is way too long. In the past we could just mine a couple of blocks. But manipulating pure time is not a good non unit tests.
Therefore it should be possible to set the withdraw timeout in the constructor of the User Deposit contract. This is the same strategy as we already do for the Token Network and Token Registry contract. The deployment tools will then contain the current constant value as the default for the new optional argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant