New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `settled` from NettingChannel Contract #1011

Closed
LefterisJP opened this Issue Sep 13, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@LefterisJP
Collaborator

LefterisJP commented Sep 13, 2017

Problem Definition

The NettingChannelLibrary has the settled attribute for the settled block. But at the block where we settle, the contract also performs a self-destruct, so this attribute is utterly useless.

Solution

Remove it and all references to it.

@LefterisJP LefterisJP self-assigned this Sep 13, 2017

@LefterisJP LefterisJP changed the title from Remove `settled` from NettingChannelContract to Remove `settled` from NettingChannel Contract Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment