Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove settled from NettingChannel Contract #1011

Closed
LefterisJP opened this issue Sep 13, 2017 · 0 comments
Closed

Remove settled from NettingChannel Contract #1011

LefterisJP opened this issue Sep 13, 2017 · 0 comments
Assignees
@LefterisJP

Comments

@LefterisJP
Copy link
Contributor

Problem Definition

The NettingChannelLibrary has the settled attribute for the settled block. But at the block where we settle, the contract also performs a self-destruct, so this attribute is utterly useless.

Solution

Remove it and all references to it.
@LefterisJP LefterisJP self-assigned this Sep 13, 2017
@LefterisJP LefterisJP changed the title Remove settled from NettingChannelContract Remove settled from NettingChannel Contract Sep 13, 2017
@LefterisJP LefterisJP mentioned this issue Sep 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LefterisJP LefterisJP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hackaugusto @LefterisJP