New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename `connection` api endpoint to `connections` #1044

Closed
LefterisJP opened this Issue Sep 19, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@LefterisJP
Collaborator

LefterisJP commented Sep 19, 2017

Problem Definition

All of our endpoints are using plural nouns since they are collections of resources. We need to make sure that connection endpoint follows this rule.

  • Rename the connection endpoint
  • Add a changelog entry.

@LefterisJP LefterisJP added this to the Next minor release milestone Sep 19, 2017

@andrevmatos

This comment has been minimized.

Collaborator

andrevmatos commented Sep 19, 2017

@LefterisJP

This comment has been minimized.

Collaborator

LefterisJP commented Sep 19, 2017

@andrevmatos Which comment do you link to? I don't understand.

That PR added the GET connection endpoint but we also have the PUT connection/token_address endpoint that will also need renaming. Which is why I did not insists on renaming on that PR.

@andrevmatos

This comment has been minimized.

Collaborator

andrevmatos commented Sep 19, 2017

It was this comment:

Wait no. Disregard this comment, we already use this endpoint to connect, so no renaming.

But if we're renaming both, of course, my concern doesn't apply.

@andrevmatos andrevmatos self-assigned this Sep 19, 2017

@LefterisJP

This comment has been minimized.

Collaborator

LefterisJP commented Sep 19, 2017

Yep, so as I said in rocketchat, I noticed this problem last week and was about to tell you to rename it but then realized it's more than one endpoint that needs renaming so better leave it for another issue (i.e.: this issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment