Smoketest fails with KeyError if no geth is installed

[ulope]

Problem Definition

If no geth binary is installed (or not on the PATH) on the user's system and no RST_GETH_BINARY env variable is defined raiden smoketest will fail with the following exception:

1/5] getting smoketest configuration
[2/5] starting ethereum
Traceback (most recent call last):
  File "build/raiden/raiden-script.py", line 2, in <module>
  File "raiden/__main__.py", line 11, in main
  File "click/core.py", line 722, in __call__
  File "click/core.py", line 697, in main
  File "click/core.py", line 1066, in invoke
  File "click/core.py", line 895, in invoke
  File "click/core.py", line 535, in invoke
  File "click/decorators.py", line 17, in new_func
  File "raiden/ui/cli.py", line 829, in smoketest
  File "raiden/tests/utils/smoketest.py", line 315, in start_ethereum
  File "string.py", line 130, in substitute
  File "string.py", line 123, in convert
  File "os.py", line 669, in __getitem__
KeyError: 'RST_GETH_BINARY'

The reason is that

raiden/raiden/tests/utils/smoketest.py

Line 315 in 86d19e6

Template(cmd).substitute(os.environ)

uses os.environ as the substitution dict and DEFAULT_ETH_COMMAND contains $RST_GETH_BINARY which won't be set if distutils.spawn.find_executable() returns None.

Solution

Verify that geth is available and if it isn't, inform the user with an actionable error message.

Tasklist

• Verify geth is available in smoketest
• Notify user and abort if it isn't
• Add a changelog entry.

[moricho]

Can I work on this issue?
I would like to contribute to this community!

[palango]

@Morito-Ikeda Sure! Let us know if you run into problems.

[gitcoinbot]

This issue now has a funding of 0.18 ETH (75.71 USD @ $420.64/ETH) attached to it.

• If you would like to work on this issue you can claim it here.
• If you've completed this issue and want to claim the bounty you can do so here
• Questions? Get help on the Gitcoin Slack
• $2748.31 more Funded OSS Work Available at: https://gitcoin.co/explorer

[gitcoinbot]

Work has been started on the 0.18 ETH (109.98 USD @ $610.98/ETH) funding by:

1. @gcarq

Please work together and coordinate delivery of the issue scope. Gitcoin doesn't know enough about everyones skillsets / free time to say who should work on what, but we trust that the community is smart and well-intentioned enough to work together. As a general rule; if you start work first, youll be at the top of the above list ^^, and should have 'dibs' as long as you follow through.

On the above list? Please leave a comment to let the funder (@vs77bb) and the other parties involved what you're working, with respect to this issue and your plans to resolve it. If you don't leave a comment, the funder may expire your submission at their discretion.

• Learn more on the gitcoin issue page
• Questions? Get help on the Gitcoin Slack
• $4956.51 more Funded OSS Work Available at: https://gitcoin.co/explorer

[gitcoinbot]

Work for 0.18 ETH (77.35 USD @ $429.72/ETH) has been submitted by:

1. @gcarq

Submitters, please leave a comment to let the funder (@vs77bb) (and the other parties involved) that you've submitted you work. If you don't leave a comment, the funder may expire your submission at their discretion.

• Learn more on the gitcoin issue page
• Questions? Get help on the Gitcoin Slack
• $2858.55 more Funded OSS Work Available at: https://gitcoin.co/explorer

[LefterisJP]

The issue is solved by @gcarq.

I am not sure how gitcoin works from this point on.

[gcarq]

@vs77bb work has been submitted and issue is solved. I'm also not sure how gitcoin works from this point on.

[gitcoinbot]

The funding of 0.18 ETH (109.98 USD @ $610.98/ETH) attached to this issue has been approved & issued to @gcarq.

• Learn more at on the gitcoin issue page
• Questions? Get help on the Gitcoin Slack
• $4956.51 more Funded OSS Work Available at: https://gitcoin.co/explorer

[vs77bb]

@LefterisJP @gcarq Apologies for the delay, the bounty funding has been released!

@LefterisJP If you are the funder, you'll have access to 'Accept Submission' immediately once a submission is made (like @gcarq did)!