New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: nicer message if token registration fails #1817

Closed
pcppcp opened this Issue Jul 13, 2018 · 0 comments

Comments

Projects
None yet
4 participants
@pcppcp
Contributor

pcppcp commented Jul 13, 2018

When trying to register an address that's not a token, an ugly red popup with a not very descriptive message is shown.

Http failure response for http://localhost:5001/api/1/tokens/0x2e83b5Ae698E1f1ab5b6F4bb0732D72F0c74D049: 409 CONFLICT => createERC20TokenNetwork transaction threw. Receipt=AttributeDict({'blockHash': HexBytes('0xb482f817700b674de180338a5caf5ec6ef6bb2999ca83fe4c0c60a691903721b'), 'blockNumber': 3627895, 'contractAddress': None, 'cumulativeGasUsed': 579344, 'gasUsed': 61609, 'logs': [], 'logsBloom': HexBytes('0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000'), 'root': None, 'status': 0, 'transactionHash': HexBytes('0xbf0e2542b671934f94185cc52858fb40031abe59bbaf6c0f92e03c29d3536113'), 'transactionIndex': 1})"

The popup should inform user what went wrong in a more understandable way.
(a past error log in the raiden webui would be also nice)

@pcppcp pcppcp added the ui label Jul 13, 2018

@LefterisJP LefterisJP added this to the Red Eyes milestone Jul 16, 2018

kelsos added a commit to kelsos/raiden that referenced this issue Jul 27, 2018

kelsos added a commit to kelsos/raiden that referenced this issue Jul 30, 2018

Change the way error messages appear on the webui
The webui should now show only the error messages as they are
returned by the rest api. In case of bad request errors it should
show messages for in the `field: message` format.

This commit should fix raiden-network#1817, raiden-network#1821

@christianbrb christianbrb added the P3 label Jul 30, 2018

@kelsos kelsos closed this in 3189b96 Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment