Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
leaving token network doesn't work #1879
Debugging this lead me to check both
One part is a bit confusiong which is that the
The confusing part here is that
Calling the leave API:
Successfully triggered all channels to close.
@rakanalh hahaha nice find. So basically the function should have been doing what the comment says it does. But as you noticed, due to using
But let's take a step back and explain the reasoning here. In the past we could not recover from an irregular shutdown. Now with the WAL we can and we do so.
Instead what we guaranteed was that you safely use Raiden and shut it down regularly. Shutting down regurarly would cause you to close all channels and only after closing and settling would the shutdown be succesfull. To make that faster while keeping the safety guarantee we added this "only_receiving" flag to do what the comment describes. But it should have been
Now that we are done with the history lesson ... I could go as far as saying we don't really need that argument anymore. So I would remove that logic completely, especially considering it's not exposed from the web UI.