New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI fails when geth's --corsdomain doesn't have the same port as raiden's --api-address #2004

Closed
rakanalh opened this Issue Jul 30, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@rakanalh
Contributor

rakanalh commented Jul 30, 2018

Problem Definition

After a little investigation, @kelsos and I found that information aren't being displayed properly on the WebUI because of the following error:

This happens when geth is ran with --corsdomain localhost:5001 and raiden's --api-address localhost:5002.

So instead of failing silently, we think it's better if the UI displays an error message that explains why the request is failing.

This issue is related to:
#1956

@rakanalh rakanalh added this to the Red Eyes milestone Jul 30, 2018

@rakanalh rakanalh added the P3 label Jul 30, 2018

kelsos added a commit to kelsos/raiden that referenced this issue Aug 1, 2018

Show a webui error when JSON-RPC requests fail
* Changes `fetchUserToken` in order to propagate JSON RPC errors
* Throw a more informative error when JSON RPC errors are encountered
* `UserToken` is not included in the channel data.
* `TokenPipe` no longer depends on `RaidenService`
* `tslint.json` now includes rules about 4 spaces in code
and whitespaces in module import

Fixes raiden-network#2004

kelsos added a commit to kelsos/raiden that referenced this issue Aug 1, 2018

Show a webui error when JSON-RPC requests fail
Changes fetchUserToken in order to propagate JSON RPC errors
Throw a more informative error when JSON RPC errors are encountered
UserToken is not included in the channel data
TokenPipe no longer depends on RaidenService
tslint.json now includes rules about 4 spaces in code and whitespaces in module import

Fixes raiden-network#2004

@kelsos kelsos closed this in 531d140 Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment