New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version the database to make breaking testnet upgrades easier #2134

Closed
hackaugusto opened this Issue Aug 9, 2018 · 1 comment

Comments

Projects
None yet
5 participants
@hackaugusto
Collaborator

hackaugusto commented Aug 9, 2018

Instead of asking users to remove the database when a breaking change is introduced, we should make a new database and leave the old one behind, in case there are still actions that need to be executed, e.g. leave the token networks.

Tasklist

  • Add a constant to define the current version of the database.
  • Use the database version as part of the database path (either the path or in the sqllite .db name)

@LefterisJP LefterisJP added this to the Red Eyes Testnet5 milestone Aug 9, 2018

@LefterisJP LefterisJP changed the title from Version the database base to easy testnet upgrades to Version the database to make breaking testnet upgrades easier Aug 10, 2018

@christianbrb christianbrb added the P2 label Aug 13, 2018

@CosminNechifor CosminNechifor self-assigned this Aug 16, 2018

@palango

This comment has been minimized.

Collaborator

palango commented Aug 20, 2018

Fixed by #2200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment