New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove block number from internal events and rearranged REST API debug endpoints #2170

Closed
palango opened this Issue Aug 13, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@palango
Collaborator

palango commented Aug 13, 2018

Problem Definition

The block number is provided through the
RaidenService.handle_state_change function, the block number used in
this function varies with the type of the state change.

Events from the blockchain can use a consistent value (the block number
from the event), but state changes for user actions or protocol messages
must use the current block number known by the node, which will vary on
restart. To avoid inconsistencies on the block_number on restarts, this
value should be removed.

WIP at #1859

@palango

This comment has been minimized.

Collaborator

palango commented Aug 30, 2018

Fixed with #1859

@palango palango closed this Aug 30, 2018

@LefterisJP LefterisJP changed the title from Remove block_number from the events storage to Remove block number from internal events and rearranged REST API debug endpoints Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment