New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to the webui the ability to view payment history with partner on token network. #2252

Closed
kelsos opened this Issue Aug 24, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@kelsos
Contributor

kelsos commented Aug 24, 2018

The rest API already provides endpoints for the payment history. This should be included on the webui so that the user can see the payment history with a partner on a token network.

@kelsos kelsos added the ui label Aug 24, 2018

@kelsos kelsos self-assigned this Aug 24, 2018

@palango

This comment has been minimized.

Collaborator

palango commented Aug 24, 2018

https://raiden-network.readthedocs.io/en/stable/rest_api.html#get--api-1-payments-(token_address)-(target_address) is not bound to a particular channel. So we need to find a proper place for it.

@kelsos

This comment has been minimized.

Contributor

kelsos commented Aug 24, 2018

@palango so there is no way currently to filter for a specific channel?

@palango

This comment has been minimized.

Collaborator

palango commented Aug 24, 2018

No, because payments are not bound to channels, only to the token and the target.

@kelsos kelsos changed the title from Add the ability to view a channel's payment history on webui. to Add to the webui the ability to view payment history with partner on token network. Aug 24, 2018

@kelsos

This comment has been minimized.

Contributor

kelsos commented Aug 24, 2018

Since the wording doesn't make any sense I changed it.
So it would not make sense making the payment history expand out of a specific channel, instead it would be better to open an entirely new page with the payment history for a token network/partner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment