New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel polling doesn't should check also token address along with channel identifier #2284

Closed
kelsos opened this Issue Aug 27, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@kelsos
Contributor

kelsos commented Aug 27, 2018

Problem Definition

Polling mechanism is making some erroneous assumptions when checking for the same channel. It currently only checks for the channel_identifier where it should also check the token_address because the channel_identifier might be repeated across token networks.

This results in balance update notifications on channels that didn't actually have an update but share the same channel identifier.

@kelsos kelsos added the ui label Aug 27, 2018

@kelsos kelsos self-assigned this Aug 27, 2018

@kelsos kelsos closed this in #2286 Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment