New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raiden node unable to process payments after a while #2293

Closed
CosminNechifor opened this Issue Aug 28, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@CosminNechifor
Collaborator

CosminNechifor commented Aug 28, 2018

Problem Definition

I have tried a second time to get my node stuck, and make it unable to process payments.
Steps I've done to get it stuck:

  1. I have created a new geth account, transfered eth to it and minted tokens. After that I restarted geth.
  2. I started the raiden client (0.6.0 release, same thing as @czepluch )
  3. I tried to send Jacob a payment and it worked
  4. I run the following script to send 50 payments of 1 token to Jacob. The first time, all payments went through and he received them.
  5. When I started it a second time (I wanted to send him 200 more payments of 1 token), it got stuck after I think 20 transactions, then I canceled it.

Even after restarting the node, I could no longer perform payments to him.

Logs:

Jacob
Cosmin

If anyone else has the time, I strongly recommend trying to see if this would happen to their node also.

System Description

Linux cosmin-Lenovo-ideapad-100-15IBD 4.15.0-33-generic #36-Ubuntu SMP Wed Aug 15 16:00:05 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
/usr/bin/solc
solc, the solidity compiler commandline interface
Version: 0.4.24+commit.e67f0147.Linux.g++
/usr/bin/geth
Geth
Version: 1.8.12-stable
Git Commit: 37685930d953bcbe023f9bc65b135a8d8b8f1488
Architecture: amd64
Protocol Versions: [63 62]
Network Id: 1
Go Version: go1.10.1
Operating System: linux
GOPATH=
GOROOT=/usr/lib/go-1.10
@LefterisJP

This comment has been minimized.

Collaborator

LefterisJP commented Aug 28, 2018

@hackaugusto Please write a description of what we discussed in-person is the side-effect that causes this bug and don't forget to add a changelog entry with your fix

@LefterisJP LefterisJP added this to the Red Eyes Testnet 7 milestone Aug 28, 2018

@hackaugusto

This comment has been minimized.

Collaborator

hackaugusto commented Aug 28, 2018

Please write a description of what we discussed in-person is the side-effect that causes this bug and don't forget to add a changelog entry with your fix

This bug was caused because the arguments message_identifier and payment_identifier where swapped.

This call:

unlock_lock = channel.send_unlock(
channel_state,
transfer_description.payment_identifier,
message_identifier,
state_change.secret,
state_change.secrethash,
)

Must have this order:

def send_unlock(
channel_state: NettingChannelState,
message_identifier: typing.MessageID,
payment_identifier: typing.PaymentID,
secret: typing.Secret,
secrethash: typing.SecretHash,
) -> SendBalanceProof:

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Aug 28, 2018

bugfix raiden-network#2293
arguments message_identifier and payment_identifier where swapped.

hackaugusto added a commit that referenced this issue Aug 28, 2018

bugfix #2293
arguments message_identifier and payment_identifier where swapped.
@CosminNechifor

This comment has been minimized.

Collaborator

CosminNechifor commented Aug 29, 2018

Fixed by: #2299

@hackaugusto hackaugusto referenced this issue Aug 31, 2018

Closed

WAL upgradability #862

0 of 15 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment