New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

payments endpoint only returns events from one perspective #2373

Closed
czepluch opened this Issue Sep 6, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@czepluch
Collaborator

czepluch commented Sep 6, 2018

Problem Definition

The GET http://localhost:5001/api/1/payments/<token_address>/<partner_address> endpoint used to return a list of events related to payments both received and sent. Now it only shows events for payments sent. I am not quite sure, but I think this commit caused it. Also looking at the tests there are only tests for EventPaymentSentSuccess events and not EventPaymentReceivedSuccess which is why I suspect that the change in the response wasn't detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment