New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure a 3rd party can't make us communicate with another party on their room #2507

Closed
andrevmatos opened this Issue Sep 17, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@andrevmatos
Collaborator

andrevmatos commented Sep 17, 2018

Problem Definition

Out of #2501 #2302
Related: #473

A---B
 \ /
  C

Currently, the node joins any rooms it's invited to (to listen for possible partners messages), and verifies only the sender of the message to update the room it uses to comunicate with that node. This allows an attacker C to invite us (A) to a room it is communicating with B, and with whom we also have a channel, which (upon seeing the first B's message) will make us update and start communicating with B on that room (which is owned/readable by C), possibly leaking sensible information once we get private/encrypted rooms.

We need to ensure the matrix invite system only accepts invites to secure (i.e: private) rooms, and only communicates/updates with that inviter node on this room.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment