REST-API: Performing a deposit with total_deposit less than current total_deposit returns 200 response

[Dominik1999]

Raiden node returns 200 SUCCESS when setting total_deposit to something smaller than current total_deposit (withdrawing)

This test runs successfully with a Raiden node.

scenario:
  serial:
         name: Scenario F11 (Depositing negative amount II)
         tasks:
           - open_channel: {from: 0, to: 1, total_deposit: 99_000_000_000_000_000_000}
           - assert: {from: 0, to: 1, total_deposit: 99_000_000_000_000_000_000, balance: 99_000_000_000_000_000_000, state: "opened"} 
           - deposit: {from: 0, to: 1, total_deposit: 1, expected_http_status: 200}
           - assert: {from: 0, to: 1, total_deposit: 99_000_000_000_000_000_000, balance: 99_000_000_000_000_000_000, state: "opened"}

Therefore, it is possible to set total_deposit to 1 token (the Raiden Node returns code 200) without changing the status of total_deposit.

I used my own token with 18 decimals.

[ulope]

The reason is this:

raiden/raiden/api/python.py

Lines 399 to 401 in 49832df

	if total_deposit <= channel_state.our_state.contract_balance:
	# no action required
	return

[Dominik1999]

ok then, this is no bug and the return code 200 is what we expect? Then I close this again

[palango]

ok then, this is no bug and the return code 200 is what we expect?

From my understanding we should return 409 CONFLICT in this case

[ulope]

Yes, this is definitely a bug IMO.

Esp. since we catch the DepositMismatch in the rest api layer:

raiden/raiden/api/rest.py

Lines 1046 to 1050 in 49832df

	except DepositMismatch as e:
	return api_error(
	errors=str(e),
	status_code=HTTPStatus.CONFLICT,
	)

which describes exactly the case you're testing:

raiden/raiden/exceptions.py

Lines 52 to 58 in b20360a

	class DepositMismatch(RaidenRecoverableError):
	""" Raised when the requested deposit is lower than actual channel deposit
	Used when a *user* tries to deposit a given amount of token in a channel,
	but the on-chain amount is already higher.
	"""
	pass

[Dominik1999]

ok nice, I found my first bug then