New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join a network - no error message when joinable_funds_target > 1 #2676

Closed
Dominik1999 opened this Issue Oct 4, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@Dominik1999
Contributor

Dominik1999 commented Oct 4, 2018

Problem Definition

When joining a network the optional argument joinable_funds_target can be set with a value on (0,1). However, when joinable_funds_target is set >1, the client joins the network (204 response) and creates channels with deposit and balance 0.

I would expect the function to throw.

@LefterisJP

This comment has been minimized.

Collaborator

LefterisJP commented Oct 5, 2018

This is indeed a bug. Let me fix that. We don't do sanity checks on joinable_funds_target and if you give something bigger than 1 you end up with a negative number inside the connection manager.

Ouch.

LefterisJP added a commit to LefterisJP/raiden that referenced this issue Oct 5, 2018

@LefterisJP LefterisJP added this to the Red Eyes Testnet 12 milestone Oct 5, 2018

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment