Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of confirmation blocks as part of the ChainState #2707

Open
hackaugusto opened this issue Oct 8, 2018 · 1 comment
Open

Add number of confirmation blocks as part of the ChainState #2707

hackaugusto opened this issue Oct 8, 2018 · 1 comment

Comments

@hackaugusto
Copy link
Contributor

Abstract

The number of confirmations blocks is not equal to all networks, specially for test networks the number of confirmation blocks usually needs to be higher then the confirmation blocks of main net.

Motivation

Allow to easily change the confirmation blocks for different networks

Specification

The ChainState needs a new field, for the number of confirmation blocks, and this data must be made available to the rest o the state machine code. The code must be updated to use the setting from the ChainState instead of the constant module.

Backwards Compatibility

This changes a state object, for forward compatibility the decoding logic of the ChainState class must add set the default value.

@hackaugusto
Copy link
Contributor Author

Related #1121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant