New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing events up to `CONFIRMATION` blocks during restart #2894

Closed
LefterisJP opened this Issue Oct 25, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@LefterisJP
Collaborator

LefterisJP commented Oct 25, 2018

Problem Definition

If we restart we can miss events up to CONFIRMATION (5) blocks when we poll the blockchain again. That is due to the block number used in the dispatched Block state change here

How it manifested

@Dominik1999 was working with Raiden and did a few frequent restarts one after another while sending an on-chain transaction. All logs here.

What he experiences is that he is trying to deposit to a channel (channel_identifier: 6, partner_address: 0xD6e68536eCe0Eac02b39317FdCE814087Bae6118) but it fails at first due to low gas. He seems to not notice it and try and deposit multiple times all the while restarting 2-3 times.

One of these transactions eventually went through but his node did not notice it through the restarts. As described in the "Problem Definition" section it is most probable that this was due to having missed the ChannelNewDeposit event and his state being inconsistent ever since.

Task

Emit the block state change with the confirmation block.

@LefterisJP LefterisJP self-assigned this Oct 25, 2018

LefterisJP added a commit to LefterisJP/raiden that referenced this issue Oct 25, 2018

@LefterisJP LefterisJP referenced this issue Oct 25, 2018

Merged

Fix 2894 #2895

konradkonrad added a commit to konradkonrad/raiden that referenced this issue Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment