New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an explicit flag to control `UnrecoverableError` behaviour #2909

Closed
LefterisJP opened this Issue Oct 27, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@LefterisJP
Collaborator

LefterisJP commented Oct 27, 2018

Problem Definition

At the moment we control the behavior of whether an UnrecoverableErrorshould crash the node or be only logged to the log via the environment type being PRODUCTION. Reasoning behind this is that we don't want to crash the user's node in production as this can cause loss of funds.

We should decouple this behaviour from the production flag so that we can properly test the production flag and so that if someone wants to test they can add the --unrecoverable-error-should-crash and have the node fail early during testing.

Task

Add --unrecoverable-error-should-crash argument to the node

@LefterisJP LefterisJP self-assigned this Oct 27, 2018

LefterisJP added a commit to LefterisJP/raiden that referenced this issue Oct 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment