Raiden crashes with "Deposit amount decreased"

[LefterisJP]

Problem Definition

This was seen only once by @czepluch during trying out latest nightly.

Network was Kovan.
Logs are here
The failing setTotalDeposit() transaction is here

Task

Investigate to see why this can be happening and fix it.

[arseneeth]

I had the same issue at the ETHSingapore hackathon. Happened on a newly registered token network, when opening the first channel.

Worked after 3 iterations

[LefterisJP]

Happened on a newly registered token network, when opening the first channel.

Thank you @arsenyjin -- this gives a hint as to what the reason for the bug may be. Do you by any chance have any logs?

[czepluch]

Weird thing here is, that for me it only happened the first time I opened a channel in a newly registered token network. In this case the crash kept happening over and over again.

[arseneeth]

I guess I posted the logs in the issue #3139

[LefterisJP]

@arsenyjin you posted 43 logs in that zip. Can you by any chance help us narrow it down by telling us which are relevant?

[LefterisJP]

Relevant log from #3139 for setTotalDepositFailed is here

[hackaugusto]

This is the stacktrace:

Traceback (most recent call last):
  File "site-packages/flask/app.py", line 1813, in full_dispatch_request
  File "site-packages/flask/app.py", line 1799, in dispatch_request
  File "site-packages/flask_restful/__init__.py", line 480, in wrapper
  File "site-packages/flask/views.py", line 88, in view
  File "site-packages/flask_restful/__init__.py", line 595, in dispatch_request
  File "site-packages/webargs/core.py", line 478, in wrapper
  File "site-packages/raiden/api/v1/resources.py", line 52, in put
  File "site-packages/raiden/api/rest.py", line 608, in open
  File "site-packages/raiden/api/python.py", line 423, in set_total_channel_deposit
  File "site-packages/raiden/network/proxies/payment_channel.py", line 164, in set_total_deposit
  File "site-packages/raiden/network/proxies/token_network.py", line 652, in set_total_deposit
  File "site-packages/raiden/network/proxies/token_network.py", line 1150, in _check_channel_state_for_deposit
raiden.exceptions.RaidenUnrecoverableError: Deposit amount decreased

This is the code at that time:

raiden/raiden/network/proxies/token_network.py

Lines 1149 to 1150 in 786347b

	elif participant_details.our_details.deposit < deposit_amount:
	raise RaidenUnrecoverableError('Deposit amount decreased')

That code was executed after the transaction was sent and mined, and the receipt result was a failure.

These are the logs relevant for the deposit.

The transaction pointed above if for a 0.3._ smart contract, available here.

These are the values used then:

>>> tn.functions.deposit_limit().call()
100000000000000000000
>>> int('00000000000000000000000000000000000000000000021e19e0c9bab2400000', 16)
10000000000000000000000

The first is the deposit_limit set in the smart contract. The later is the value given in the transaction. So, the problem was this require require(total_deposit <= deposit_limit);