Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connectionmanager attempt deposit with 0 funds if allocated funds are too low #3380

Closed
2 tasks
LefterisJP opened this issue Jan 31, 2019 · 0 comments
Closed
2 tasks

Connectionmanager attempt deposit with 0 funds if allocated funds are too low #3380

LefterisJP opened this issue Jan 31, 2019 · 0 comments
Assignees
@LefterisJP
Labels
Severity / Minor
Projects
Raiden Client

Comments

@LefterisJP
Copy link
Contributor

Problem Definition

This was reported by a gitter user here.

He essentially gave funds=1 in the connect endpoint, which resulted in making deposits of 0.

Task

  • The connection manager should not attempt to make a deposit if the funds it plans to lock are 0.
  • Invoking api's set total deposit with 0 funds should be an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LefterisJP LefterisJP

Labels
Severity / Minor
Projects
No open projects
Raiden Client
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LefterisJP