Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reward monitoring service #3462

Closed
rakanalh opened this issue Feb 11, 2019 · 5 comments
Closed

Reward monitoring service #3462

rakanalh opened this issue Feb 11, 2019 · 5 comments
Assignees
Milestone

Comments

@rakanalh
Copy link
Contributor

rakanalh commented Feb 11, 2019

Introduction

A flag --enable-monitoring was introduced into Raiden for the user to specify the intent of whether a monitoring service should be used or not. If monitoring is enabled, when a channel has more than X tokens (capacity) deposited, Raiden automatically sends the latest balance proof to the monitoring service.

Requirements

  • The user needs to set the minimum capacity at which at the monitoring service will be used.
  • The user needs to set the amount to be paid for the monitoring service, which is going to be used here:
    reward_amount = 0 # FIXME: default reward is 0, should come from elsewhere
  • Only If monitoring is enabled, publish balance proof

Expected: End of Feb, 2019.

@rakanalh rakanalh added this to the Ithaca milestone Feb 11, 2019
@LefterisJP
Copy link
Contributor

Part of #216. As defined here: #216 (comment)

Requirement:
* The user needs to set the minimum capacity at which at the monitoring service will be used

Since the price of the underlying token can vary with time see ideas for a price oracle show in the parent issue: here and here

Requirement:
* The user needs to set the amount to be paid for the monitoring service.

I am not sure this is possible. The advertised MS prices are non-binding on their side. So can't guarantee that in any way in the client. Is my understanding correct @palango ?

* How would i know the prices for different MS nodes running? would monitoring services publish their prices over the wire every X period?

The MSes were supposed to advertise their prices in the same broadcast room the clients publish their BPs. Source: The Spec

  • What are the default values?

That's too dynamic for a set default. I would say something like the average of the advertised MS prices as seen in the broadcast room with a user configurable +X% of tolerance.

@palango
Copy link
Contributor

palango commented Feb 13, 2019

The advertised MS prices are non-binding on their side. So can't guarantee that in any way in the client. Is my understanding correct @palango ?

Yes, this is right. Short term there is no way of knowing the current price for a monitor request. Longer term the plan is to add a broadcasted channel in which the MS show their current price, which then can be used by the client to get a better picture.

@rakanalh rakanalh changed the title User Policy - Set the maximum fee for MS Reward monitoring service Feb 15, 2019
@LefterisJP
Copy link
Contributor

Yes, this is right. Short term there is no way of knowing the current price for a monitor request.

@palango @rakanalh We discussed this in the OKR meeting yesterday but for the short term the easiest solution would be constant prices for monitoring so that there is no need for the client to learn the price. We know it by default since it will be constant.

Is my understanding of the consensus on the meeting on this correct?

@rakanalh
Copy link
Contributor Author

Correct, we should use a constant value until MS implements price publishing.

@LefterisJP
Copy link
Contributor

LefterisJP commented Feb 15, 2019

@rakanalh So can you edit the issue's open questions? My comment should answer both.

@rakanalh rakanalh self-assigned this Feb 25, 2019
@rakanalh rakanalh moved this from To do to In progress in Raiden Client Feb 25, 2019
Raiden Client automation moved this from In progress to Done Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Raiden Client
  
Done
Development

No branches or pull requests

3 participants