Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payment Endpoint not containing token addresses #5589

Closed
manuelwedler opened this issue Jan 7, 2020 · 0 comments · Fixed by #5593
Closed

Payment Endpoint not containing token addresses #5589

manuelwedler opened this issue Jan 7, 2020 · 0 comments · Fixed by #5593
Assignees
@LefterisJP
Labels
Component / API Issues that relate the the APIs Raiden provides.
Projects
Raiden Berlin Sprint
Milestone
Alderaan

Comments

@manuelwedler
Copy link
Contributor

Problem Definition

The response of the payments API endpoint does not contain any token address. It is not possible to match a payment event to a token. See this example response:

[{"identifier": "1577096876720", "initiator": "0xb36B19a15E10dF46443BA962FaE413FC680dA977", "amount": "100000000000000", "log_time": "2019-12-23T10:27:59.832000", "event": "EventPaymentReceivedSuccess"}, {"identifier": "1577100288665", "amount": "10000000000", "log_time": "2019-12-23T11:24:51.928000", "target": "0xb36B19a15E10dF46443BA962FaE413FC680dA977", "event": "EventPaymentSentSuccess"}]

We need a field token_address which makes it possible to know which event corresponds to which token.

System Description

Raiden v0.100.5a1.dev1099+g49e2d579e
@manuelwedler manuelwedler added the Component / API Issues that relate the the APIs Raiden provides. label Jan 7, 2020
@Dominik2002 Dominik2002 added this to In progress in Raiden Berlin Sprint Jan 7, 2020
LefterisJP added a commit to LefterisJP/raiden that referenced this issue Jan 7, 2020
@LefterisJP
Include token_address in all payment events returned by the API
9bd4ee2 
Fix raiden-network#5589
@LefterisJP LefterisJP mentioned this issue Jan 7, 2020
Merged
13 tasks
@LefterisJP LefterisJP moved this from In progress to Review in progress in Raiden Berlin Sprint Jan 7, 2020
@Dominik2002 Dominik2002 added this to the Alderaan milestone Jan 7, 2020
Raiden Berlin Sprint automation moved this from Review in progress to Done Jan 8, 2020
palango pushed a commit that referenced this issue Jan 8, 2020
@LefterisJP @palango
Include token_address in all payment events returned by the API
25f4bea 
Fix #5589
hackaugusto pushed a commit that referenced this issue May 29, 2020
@LefterisJP @hackaugusto
Include token_address in all payment events returned by the API
c0e97b0 
Fix #5589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LefterisJP LefterisJP

Labels
Component / API Issues that relate the the APIs Raiden provides.
Projects
Raiden Berlin Sprint
  
Done
Milestone
Alderaan
Development

Successfully merging a pull request may close this issue.

Include token_address in all events returned by the REST API LefterisJP/raiden
3 participants
@LefterisJP @manuelwedler @Dominik2002