New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block raiden startup until the ethereum client is fully synchronized #670

Closed
hackaugusto opened this Issue Jun 21, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@hackaugusto
Collaborator

hackaugusto commented Jun 21, 2017

Problem Definition

Raiden may be connected to an ethereum client that is not fully synchronized, under this circumstance the ethereum client will not provided the latest events required by the Raiden node, this would effectively make Raiden unaware of channel changes and could lead to token loss.

Solution

Wait for the geth node to fully synchronize before starting to operate.

This is only a proper solution if the Raiden node is starting fresh, i.e. the first run without pending transfers, and it's only as a tool to prevent bad behavior, it's not sufficient for scenarios were the ethereum client had it's database deleted, we cannot prevent that from happening and there is not way to recover aside from wait until the database is synchronized, for this scenario third parties are required to provide safe operation and are outside of the scope of this issue.

Tasklist

  • On startup query the ethereum node and hold until it's synchronized.
@LefterisJP

This comment has been minimized.

Show comment
Hide comment
@LefterisJP

LefterisJP Jun 21, 2017

Collaborator

Also note that to determine syncing and if the user is using a light node then the eth_syncing call does not seem to work.

Collaborator

LefterisJP commented Jun 21, 2017

Also note that to determine syncing and if the user is using a light node then the eth_syncing call does not seem to work.

@roynalnaruto

This comment has been minimized.

Show comment
Hide comment
@roynalnaruto

roynalnaruto Jul 30, 2017

@hackaugusto @LefterisJP I would like to work on this issue.

roynalnaruto commented Jul 30, 2017

@hackaugusto @LefterisJP I would like to work on this issue.

@LefterisJP

This comment has been minimized.

Show comment
Hide comment
@LefterisJP

LefterisJP Aug 4, 2017

Collaborator

@roynalnaruto Sorry for getting back later to you. Please go ahead if you want to.

Collaborator

LefterisJP commented Aug 4, 2017

@roynalnaruto Sorry for getting back later to you. Please go ahead if you want to.

@LefterisJP LefterisJP added this to the Next minor release milestone Sep 14, 2017

@hackaugusto hackaugusto self-assigned this Sep 14, 2017

@konradkonrad konradkonrad modified the milestones: Next minor release, Next patch release Sep 14, 2017

@LefterisJP LefterisJP added the 1 label Sep 14, 2017

@ulope ulope referenced this issue Sep 16, 2017

Closed

Can't start Raiden without internet connection #870

3 of 3 tasks complete
@LefterisJP

This comment has been minimized.

Show comment
Hide comment
@LefterisJP

LefterisJP Sep 20, 2017

Collaborator

It's fixed by #882

Collaborator

LefterisJP commented Sep 20, 2017

It's fixed by #882

@LefterisJP LefterisJP closed this Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment