Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Can't start Raiden without internet connection #870
Upon start Raiden tries to gain external connectivity via UPNP or STUN. If no internet connection is available both methods fail and Raiden crashes with
In normal use this would only be a cosmetic issue (exception instead of a more user friendly error messge) since the public chain isn't accessible w/o internet anyway. However usage scenarios in isolated networks on a private chain are certainly imaginable and should be supported.
Don't crash if both UPNP and STUN are unavailable but instead print a warning and fall back to using the local ip / port.
Can't we assume that UPNP is required to work on private networks?
If we can't, an approach is to re-add the
if we're talking about an isolated network there isn't anything it could do and in "enterprise" environments UPNP is an absolute no-go.
If we want to provide an option to the user I think we should borrow some ideas from parity's
Its help says:
Since we support more than UPNP I'd suggest to use the following "methods":
Another approach would be not automatically fall back to None in any of the cases but rather fail with an error message and require the user to explicitly specify
Related to this, as we're handling startup connection issues, I'd like to request handling this exception too, which happens when Eth node and Raiden are started together, as Raiden tries to connect too soon to the Eth node, while
Raiden then exit after this exception.