New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gas_price overwrite from cli #1097

Merged
merged 3 commits into from Nov 13, 2017

Conversation

Projects
None yet
3 participants
@hackaugusto
Collaborator

hackaugusto commented Oct 26, 2017

No description provided.

@palango

This comment has been minimized.

Collaborator

palango commented Oct 26, 2017

Can you rebase and maybe but the unrelated changes (regexes, except ...) in its own commit. Otherwise looks good.

@hackaugusto hackaugusto force-pushed the hackaugusto:gas_price branch from 510913a to 919dc0f Oct 26, 2017

@hackaugusto hackaugusto referenced this pull request Oct 26, 2017

Closed

Gas price ropsten #1100

@LefterisJP

This comment has been minimized.

Collaborator

LefterisJP commented Nov 13, 2017

Also looks good to me but requires a changelog entry too, as it adds a new CLI argument.

@hackaugusto hackaugusto force-pushed the hackaugusto:gas_price branch from 919dc0f to 7e17382 Nov 13, 2017

@hackaugusto

This comment has been minimized.

Collaborator

hackaugusto commented Nov 13, 2017

done

@LefterisJP

This comment has been minimized.

Collaborator

LefterisJP commented Nov 13, 2017

approved

@hackaugusto hackaugusto merged commit 3a12cc8 into raiden-network:master Nov 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hackaugusto hackaugusto deleted the hackaugusto:gas_price branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment