New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify jsonrpc constructor #2066
Merged
palango
merged 3 commits into
raiden-network:master
from
hackaugusto:simplify_jsonrpc_constructor
Aug 7, 2018
Merged
Simplify jsonrpc constructor #2066
palango
merged 3 commits into
raiden-network:master
from
hackaugusto:simplify_jsonrpc_constructor
Aug 7, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackaugusto
force-pushed
the
simplify_jsonrpc_constructor
branch
2 times, most recently
from
August 5, 2018 20:56
3e3a94f
to
68dda4d
Compare
The arguments host and port were ignored the argument web3 was given, this could lead to inconsistencies among the web3 instance and the JSONRPCClient's attributes host/port. This change removes the extranous arguments and requires the web3 instance. [ci integration]
[ci integration]
hackaugusto
force-pushed
the
simplify_jsonrpc_constructor
branch
from
August 6, 2018 15:17
68dda4d
to
3e3d060
Compare
palango
approved these changes
Aug 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
raiden/ui/cli.py
Outdated
try: | ||
node_version = web3.version.node # pylint: disable=no-member | ||
except ConnectTimeout: | ||
raise EthNodeCommunicationError('couldnt reach the ethereum node') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we display this anywhere, but I would write Couldn't connect to the ethereum node
err508
added a commit
to err508/raiden
that referenced
this pull request
Aug 7, 2018
After raiden-network#2066 the function is unused and superfluous. Additionally, raiden-network#2066 implicitly resolved raiden-network#2027 by replacing `eth-endpoint_to_hostport`. The helper had a bug resolving tls rpc-endpoints. Closes raiden-network#2027
LefterisJP
pushed a commit
that referenced
this pull request
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review after #2064
The arguments host and port were ignored the argument web3 was given,
this could lead to inconsistencies among the web3 instance and the
JSONRPCClient's attributes host/port. This change removes the extranous
arguments and requires the web3 instance