New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on-chain secret reveal is the same as off-chain #2602

Merged
merged 3 commits into from Sep 28, 2018

Conversation

Projects
None yet
2 participants
@hackaugusto
Collaborator

hackaugusto commented Sep 25, 2018

If a secret is revealed on-chain then all the world knows it, including
the next hop of the transfer, therefore the initiator doesn't need to
wait for the next hop to send a secret reveal message to confirm that it
knows the secret.

@rakanalh

This comment has been minimized.

Contributor

rakanalh commented Sep 27, 2018

Reviewing this

@rakanalh

LGTM, fixed failing test

@rakanalh rakanalh force-pushed the hackaugusto:initiator_unlock_on_chain_reveal branch 2 times, most recently from 3b3660c to 7f1d5a7 Sep 27, 2018

hackaugusto and others added some commits Sep 25, 2018

on-chain secret reveal is the same as off-chain
If a secret is revealed on-chain then all the world knows it, including
the next hop of the transfer, therefore the initiator doesn't need to
wait for the next hop to send a secret reveal message to confirm that it
knows the secret.

@rakanalh rakanalh force-pushed the hackaugusto:initiator_unlock_on_chain_reveal branch from 7f1d5a7 to aa157a5 Sep 27, 2018

@hackaugusto hackaugusto merged commit 99ffbeb into raiden-network:master Sep 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@hackaugusto hackaugusto deleted the hackaugusto:initiator_unlock_on_chain_reveal branch Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment