New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy must not send empty secret register txs #2934

Merged
merged 2 commits into from Nov 5, 2018

Conversation

Projects
None yet
3 participants
@hackaugusto
Collaborator

hackaugusto commented Oct 31, 2018

fix #2934

@LefterisJP

This comment has been minimized.

Collaborator

LefterisJP commented Oct 31, 2018

@rakanalh Where you not showing this to me today in a branch you had while debugging Jochen's logs too?

@rakanalh

This comment has been minimized.

Contributor

rakanalh commented Oct 31, 2018

Ahh yea... for some reason i wanted to make a PR for this later on

@LefterisJP

This comment has been minimized.

Collaborator

LefterisJP commented Oct 31, 2018

Can you also add a changelog entry so that we track the improvements? made an issue for this at #2936

hackaugusto added some commits Oct 31, 2018

@hackaugusto hackaugusto force-pushed the hackaugusto:bugfix_secret_register branch from 8193a9b to 8fa63b3 Nov 4, 2018

@hackaugusto hackaugusto merged commit cc14d28 into raiden-network:master Nov 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@hackaugusto hackaugusto deleted the hackaugusto:bugfix_secret_register branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment