Update raiden-contracts to 0.19.0 #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirapira
force-pushed
the
raiden-contracts-0-19-0
branch
from
183ee39
to
de86e5f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4043 +/- ##
=========================================
Coverage ? 75.26%
=========================================
Files ? 112
Lines ? 15544
Branches ? 2177
=========================================
Hits ? 11699
Misses ? 3077
Partials ? 768
Continue to review full report at Codecov.
|
|
I'll point this to |
pirapira
force-pushed
the
raiden-contracts-0-19-0
branch
2 times, most recently
from
40e7073
to
00ffdca
Compare
pirapira
force-pushed
the
raiden-contracts-0-19-0
branch
from
00ffdca
to
2a9dc64
Compare
rakanalh
reviewed
May 14, 2019
pirapira
force-pushed
the
raiden-contracts-0-19-0
branch
from
2a9dc64
to
8a9da30
Compare
|
Unfortunately, I think |
pirapira
added a commit
to pirapira/raiden-contracts
that referenced
this pull request
May 14, 2019
because having eth-abi<=1.2.2 in requirements.txt caused undesirable downgrade in `raiden` package. raiden-network/raiden#4043 (comment)
This was referenced May 14, 2019
pirapira
force-pushed
the
raiden-contracts-0-19-0
branch
from
8a9da30
to
08c2ead
Compare
rakanalh
approved these changes
May 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and pass the unit tests.
Maybe avoid merging this into
masteruntil the next client release.I expect some test failures at this point (I only fixed the unit tests).