Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raiden-contracts to 0.19.0 #4043

merged 8 commits into from May 15, 2019


Copy link

@pirapira pirapira commented May 9, 2019

and pass the unit tests.

Maybe avoid merging this into master until the next client release.

I expect some test failures at this point (I only fixed the unit tests).

Copy link

codecov bot commented May 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a91ce7e). Click here to learn what that means.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4043   +/-   ##
  Coverage          ?   75.26%           
  Files             ?      112           
  Lines             ?    15544           
  Branches          ?     2177           
  Hits              ?    11699           
  Misses            ?     3077           
  Partials          ?      768
Flag Coverage Δ
#fuzz 35.28% <50%> (?)
#integration 67.25% <75%> (?)
#unit 52.29% <75%> (?)
Impacted Files Coverage Δ
raiden/ui/ 24.03% <ø> (ø)
raiden/ui/ 37.09% <ø> (ø)
raiden/ 95.65% <ø> (ø)
raiden/blockchain/ 91.17% <ø> (ø)
raiden/ 82.51% <100%> (ø)
raiden/ 91.89% <100%> (ø)
raiden/utils/ 94.39% <100%> (ø)
raiden/ 100% <100%> (ø)
raiden/ 81.81% <100%> (ø)
raiden/utils/ 87.14% <100%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a91ce7e...68138c0. Read the comment docs.

Copy link
Contributor Author

I'll point this to develop, once develop branch is created.

constraints.txt Outdated Show resolved Hide resolved
constraints.txt Outdated Show resolved Hide resolved
Copy link
Contributor Author

Unfortunately, make install; pip check shows raiden-contracts 0.19.0 has requirement eth-abi<=1.2.2, but you have eth-abi 1.3.0.

I think requirements.txt and requirements-dev.txt should specify different constraints in raiden-contracts.

@pirapira pirapira closed this May 14, 2019
pirapira added a commit to pirapira/raiden-contracts that referenced this pull request May 14, 2019
because having eth-abi<=1.2.2 in requirements.txt caused
undesirable downgrade in `raiden` package.

raiden-network/raiden#4043 (comment)
@pirapira pirapira reopened this May 14, 2019
@palango palango merged commit c2dfbbc into raiden-network:master May 15, 2019
@palango palango mentioned this pull request May 15, 2019
@pirapira pirapira deleted the raiden-contracts-0-19-0 branch May 16, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants