Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not used, shadows built-in variables #996

Merged
merged 1 commit into from Dec 9, 2017

Conversation

@dongsam
Copy link
Contributor

commented Sep 10, 2017

  • Removed what datadir in find_datadir() is not used by fully covered by if statements
  • Fix argument name file of _serve_webui to file_name for avoid collision with python built-in object file

Added predefine self.wsgiserver in __init__ of APIServer for start() and stop()

@LefterisJP

This comment has been minimized.

Copy link
Collaborator

commented Sep 22, 2017

@dongsam

First off apologies for the quite late reply.

We are in the process of creating a CLA for contributing to raiden as a prerequisite for commiting to the repository. Until this is finalized we can not accept any PRs. We ask for your patience and thank you for wanting to contribute to Raiden.

@palango

This comment has been minimized.

Copy link
Collaborator

commented Dec 8, 2017

Thanks for your PR @dongsam . We now have our CLA in place. Please rebase your PR, sign the CLA and add the Please review tag to this PR.

@LefterisJP

This comment has been minimized.

Copy link
Collaborator

commented Dec 8, 2017

@dongsam I would also like to ask you to rebase and make sure there are no merge commits. Squash them all into one.

@dongsam dongsam force-pushed the dongsam:fix-some-variables branch from e015f71 to 7dbbf13 Dec 8, 2017

@CLAassistant

This comment has been minimized.

Copy link

commented Dec 8, 2017

CLA assistant check
All committers have signed the CLA.

@dongsam

This comment has been minimized.

Copy link
Contributor Author

commented Dec 8, 2017

@LefterisJP @palango I just rebase and sign the CLA, Thanks

@palango

This comment has been minimized.

Copy link
Collaborator

commented Dec 8, 2017

Added predefine self.wsgiserver in init of APIServer for start() and stop()

Did you forget to commit this or is this not any issue any more?

@dongsam dongsam changed the title Fix not used, shadows built-in, defined outside __init__ variables Fix not used, shadows built-in variables Dec 8, 2017

@dongsam

This comment has been minimized.

Copy link
Contributor Author

commented Dec 8, 2017

@palango yeah That was solved by another commit after my pull request

@palango

This comment has been minimized.

Copy link
Collaborator

commented Dec 8, 2017

@dongsam Can you please change the commit title as well? git commit --amend is your friend.

@dongsam dongsam force-pushed the dongsam:fix-some-variables branch from 7dbbf13 to c4c855e Dec 9, 2017

@palango

palango approved these changes Dec 9, 2017

@palango palango merged commit 5a7fe7d into raiden-network:master Dec 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.