feat: implement batch_delete #157
Merged
+488
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magurotuna
changed the title
magurotuna
commented
Sep 19, 2021
Comment on lines
+107
to
+108
| const RETRY: usize = 5; | ||
| const MAX_ITEMS_PER_REQUEST: usize = 25; |
There was a problem hiding this comment.
For now, the limit of the number of items per request is taken into account, but the limit of whole data of a request (16MB) is not. Ideally this also should be taken into account but I think it's ok for the moment, because it seems to be very rare that the data size of 25 items exceeds 16MB in total.
bokuweb
approved these changes
Sep 21, 2021
Comment on lines
+137
to
+139
| use ::raiden::IntoAttribute as _; | ||
| use ::raiden::IntoAttrName as _; | ||
| use ::raiden::DynamoDb as _; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR does the following:
ConditionFilledOrWaitConjunctionto::raiden::ConditionFilledOrWaitConjunction)IntoAttribute,IntoAttrName, andDynamoDbtrait at the beginning of the macro expansion2 and 3 will allow us to derive
Raidenmacro without having to import other items fromraiden. In other words, all we will need to import to derive is justraiden::Raiden.What can I check for bug fixes?
I added test cases to confirm batch_delete works for basic usecases.