Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using AMS with rails 6 #2320

Open
auscaster opened this issue Mar 2, 2019 · 5 comments

Comments

@auscaster
Copy link

commented Mar 2, 2019

Hey team,

I see that AMS currently restricts Rails version to < 6. Its currently the only gem in my bundle preventing the upgrade. Is there any plans for support or a way to use this gem with Rails 6?

Thanks for your great work!

@wasifhossain

This comment has been minimized.

Copy link
Member

commented Mar 2, 2019

Thanks @auscaster for bringing it up.

@bf4 I found the tests for 0-10-stable pass on Rails master. can we push rails version to 6 at this point, or should we wait until its officially released.

Otherwise, can you suggest how can we use rails 6 beta (which is released) with the present settings? Thanks

@iggant

This comment has been minimized.

Copy link

commented Mar 9, 2019

@auscaster with this restriction < 6 you still can install beta2 Rails,
but before you can do this, you probable have to merge #2319 otherwise log file will blow up with deprecation warning log entries

This PR is almost ready to merge.

@jarkko

This comment has been minimized.

Copy link

commented Apr 26, 2019

Rails is now at 6.0.0.rc1, so the < 6 doesn't work anymore. Gonna fork and see how things work with it.

@wasifhossain

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

will make the change to make it work with the latest Rails version soon.

@wasifhossain

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

Travis is all good with Rails 6.0.0.rc1. Please have a look at the PR. I have also tested it in a project by trying to upgrade Rails from 5.2.3 to 6.0.0.rc1 and it ran successfully.

@auscaster @jarkko can you please check it out? thanks

@tynmarket tynmarket referenced this issue May 12, 2019
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.