use associated_data.ids #509

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@marshall-lee

Attempt to bring some optimization.

use associated_data.ids
Attempt to bring some optimization.
@marshall-lee

This comment has been minimized.

Show comment Hide comment
@marshall-lee

marshall-lee Feb 11, 2014

:( Tests are failing on 4.0.0 but it has been fixed rails/rails@e011258

:( Tests are failing on 4.0.0 but it has been fixed rails/rails@e011258

@steveklabnik

This comment has been minimized.

Show comment Hide comment
@steveklabnik

steveklabnik Jul 28, 2014

Contributor

Can we get some kind of benchmarking to show if this is actually an optimization?

Contributor

steveklabnik commented Jul 28, 2014

Can we get some kind of benchmarking to show if this is actually an optimization?

@steveklabnik

This comment has been minimized.

Show comment Hide comment
@steveklabnik

steveklabnik Aug 22, 2014

Contributor

Without a benchmark, I'm not willing to make a performance-based change like this. If you can get me one we can talk. Thanks.

Contributor

steveklabnik commented Aug 22, 2014

Without a benchmark, I'm not willing to make a performance-based change like this. If you can get me one we can talk. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment