Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Why did you get rid of active_model_serializer method? #575

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants

undr commented Jun 22, 2014

Why did you get rid of active_model_serializer method? I have a few models which together use one serializer. I redefine active_model_serializer method in models and it worked fine in previous version.

What reason of getting rid of this method is?

PS: Just in case I put pull request which returns this method

@steveklabnik steveklabnik commented on an outdated diff Jul 28, 2014

```ruby
-render json: @post, serializer: FancyPostSerializer
+render :json => @post, :serializer => FancyPostSerializer
@steveklabnik

steveklabnik Jul 28, 2014

Contributor

This change isn't needed.

Contributor

steveklabnik commented Jul 28, 2014

I wouldn't mind bringing this back, as you mention, it's an interface regression. Would you mind rebasing this and reverting to the 1.9 syntax? Thanks!

undr commented Jul 29, 2014

I've made all needed, but TravisCI's some specs have been failed. Actually, I have no idea why :( I've checked other PRs. All of them from April have been failed too.

Do you have any suggestions? What should I change to avoid failing specs?

Contributor

steveklabnik commented Jul 29, 2014

I'll look into it.

undr commented Jul 29, 2014

Thanks!

undr commented Jul 29, 2014

It affects on only rubinus environment and I found this issue.
travis-ci/travis-ci#2542

When Travis-IC ran specs version of rbx-2 pointed to 2.2.6. I've tried to run spec on rubinius 2.2.7 and problem is gone. Maybe, It makes a sense to change rbx-2 to rbx-2.2.7 into travis.yml, don't?

I hope it helps.

Contributor

steveklabnik commented Aug 22, 2014

So sorry! The tests have since been fixed, and this PR is outdated, so it would need a rebase. However, today, I am turning the master branch into the 0-9-stable branch. So please re-open it against 0-9-stable. Thank you / I'm sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment