Auto-include url_helpers for Rails-apps. Fixes #563 #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveklabnik
added a commit
that referenced
this pull request
Oct 14, 2014
Auto-include url_helpers for Rails-apps. Fixes #563
|
This looks great, thank you! |
|
Apologies for resurrecting a year old thread, but I see this change being reverted here . Is there an alternative recommended approach for using route helpers for links now ? |
|
@lorefnon You're commenting on an 0.9 issue referencing 0.10 code. Please open a new issue. Also, the PR you referenced was an accidental merge of a feature that was split into two PRs. See #1313 and #1289 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This pull-request adds ability to call rails url_helper methods from ActiveModel::Serializer classes.
P.S. For now I'm trying to figure out why travis build does not pass in some cases.