Skip to content

Commit 09578c2

Browse files
author
Anna
committed
no need to check for ruby 1.8.7. It's not supported
1 parent 9a4d4fd commit 09578c2

File tree

4 files changed

+1
-9
lines changed

4 files changed

+1
-9
lines changed

lib/active_record/connection_adapters/sqlserver/quoting.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,6 @@ def quoted_datetime(value)
7171
if value.is_a?(Date)
7272
time_zone_qualified_value.to_time.xmlschema.to(18)
7373
else
74-
# CHANGED [Ruby 1.8] Not needed when 1.8 is dropped.
75-
if value.is_a?(ActiveSupport::TimeWithZone) && RUBY_VERSION < '1.9'
76-
time_zone_qualified_value = time_zone_qualified_value.to_time
77-
end
7874
time_zone_qualified_value.iso8601(3).to(22)
7975
end
8076
else

test/cases/sqlserver_helper.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,12 @@ def connection_mode_odbc? ; ActiveRecord::Base.connection.instance_variable_get(
131131
def sqlserver_2005? ; ActiveRecord::Base.connection.sqlserver_2005? ; end
132132
def sqlserver_2008? ; ActiveRecord::Base.connection.sqlserver_2008? ; end
133133
def sqlserver_azure? ; ActiveRecord::Base.connection.sqlserver_azure? ; end
134-
def ruby_19? ; RUBY_VERSION >= '1.9' ; end
135134
end
136135
def connection_mode_dblib? ; self.class.connection_mode_dblib? ; end
137136
def connection_mode_odbc? ; self.class.connection_mode_odbc? ; end
138137
def sqlserver_2005? ; self.class.sqlserver_2005? ; end
139138
def sqlserver_2008? ; self.class.sqlserver_2008? ; end
140139
def sqlserver_azure? ; self.class.sqlserver_azure? ; end
141-
def ruby_19? ; self.class.ruby_19? ; end
142140
def with_enable_default_unicode_types?
143141
ActiveRecord::ConnectionAdapters::SQLServerAdapter.enable_default_unicode_types.is_a?(TrueClass)
144142
end

test/cases/unicode_test_sqlserver.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class UnicodeTestSqlserver < ActiveRecord::TestCase
3838
else
3939
raise 'need to add a case for this'
4040
end
41-
assert_equal Encoding.find('UTF-8'), data.nvarchar.encoding if ruby_19?
41+
assert_equal Encoding.find('UTF-8'), data.nvarchar.encoding
4242
end
4343

4444
end

test/profile/gc_profile_case.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
require 'models/topic'
44
require 'models/reply'
55

6-
raise "GC allocation benchmarks only supported on Ruby 1.9!" unless RUBY_VERSION >= '1.9'
7-
86
class GcProfileCase < ActiveRecord::TestCase
97

108
fixtures :topics

0 commit comments

Comments
 (0)