[Rails5] Performance optimizations.

These changes make the full ActiveRecord test suite run about 100s faster from ~580s to ~480s.

* Use the `schema_cache.columns` for the `#primary_keys` method.
* Ensure that `exec_query` uses the proper arity/arg names. Namely `:prepare` opt.
* Ensure all view checks/methods used in `#columns` only.
* Removed view table name detection in `with_identity_insert_enabled` method for fixtures.
* Removed `#select` abstract adapter override since it was the same.

Author: metaskills

CHANGELOG.md

@@ -16,6 +16,7 @@
 #### Removed
 
 * ODBC connection mode. Not been maintained since Rails 4.0.
+* View table name detection in `with_identity_insert_enabled` method for fixtures. Perf hit.
 
 #### Fixed
 

lib/active_record/connection_adapters/sqlserver/database_statements.rb

@@ -15,8 +15,8 @@ def execute(sql, name = nil)
           end
         end
 
-        def exec_query(sql, name = 'SQL', binds = [], sqlserver_options = {})
-          sp_executesql(sql, name, binds)
+        def exec_query(sql, name = 'SQL', binds = [], prepare: false)
+          sp_executesql(sql, name, binds, prepare: prepare)
         end
 
         def exec_insert(sql, name, binds, pk = nil, _sequence_name = nil)
@@ -125,7 +125,7 @@ def execute_procedure(proc_name, *variables)
         end
 
         def with_identity_insert_enabled(table_name)
-          table_name = quote_table_name(table_name_or_views_table_name(table_name))
+          table_name = quote_table_name(table_name)
           set_identity_insert(table_name, true)
           yield
         ensure
@@ -197,10 +197,6 @@ def newsequentialid_function
 
         protected
 
-        def select(sql, name = nil, binds = [])
-          exec_query(sql, name, binds)
-        end
-
         def sql_for_insert(sql, pk, id_value, sequence_name, binds)
           if pk.nil?
             table_name = query_requires_identity_insert?(sql)
@@ -231,8 +227,10 @@ def do_execute(sql, name = 'SQL')
 
         def sp_executesql(sql, name, binds, options = {})
           options[:ar_result] = true if options[:fetch] != :rows
-          types, params = sp_executesql_types_and_parameters(binds)
-          sql = sp_executesql_sql(sql, types, params, name)
+          unless without_prepared_statement?(binds)
+            types, params = sp_executesql_types_and_parameters(binds)
+            sql = sp_executesql_sql(sql, types, params, name)
+          end
           raw_select sql, name, binds, options
         end
 

lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -80,7 +80,7 @@ def new_column(name, default, sql_type_metadata, null, table_name, default_funct
         end
 
         def primary_keys(table_name)
-          primaries = columns(table_name).select(&:is_primary?).map(&:name)
+          primaries = schema_cache.columns(table_name).select(&:is_primary?).map(&:name)
           primaries.present? ? primaries : identity_columns(table_name).map(&:name)
         end
 
@@ -254,7 +254,7 @@ def column_definitions(table_name)
           end
           database    = identifier.fully_qualified_database_quoted
           view_exists = view_exists?(table_name)
-          view_tblnm  = table_name_or_views_table_name(table_name) if view_exists
+          view_tblnm  = view_table_name(table_name) if view_exists
           sql = %{
             SELECT DISTINCT
             #{lowercase_schema_reflection_sql('columns.TABLE_NAME')} AS table_name,
@@ -307,7 +307,7 @@ def column_definitions(table_name)
           nv128 = SQLServer::Type::UnicodeVarchar.new limit: 128
           binds << Relation::QueryAttribute.new('TABLE_NAME', identifier.object, nv128)
           binds << Relation::QueryAttribute.new('TABLE_SCHEMA', identifier.schema, nv128) unless identifier.schema.blank?
-          results = sp_executesql(sql, 'SCHEMA', binds)
+          results = sp_executesql(sql, 'SCHEMA', binds, prepare: true)
           results.map do |ci|
             ci = ci.symbolize_keys
             ci[:_type] = ci[:type]
@@ -446,10 +446,6 @@ def view_information(table_name)
           view_info
         end
 
-        def table_name_or_views_table_name(table_name)
-          view_exists?(table_name) ? view_table_name(table_name) : table_name
-        end
-
         def views_real_column_name(table_name, column_name)
           view_definition = view_information(table_name)[:VIEW_DEFINITION]
           return column_name unless view_definition

test/cases/adapter_test_sqlserver.rb

@@ -396,15 +396,6 @@ class AdapterTestSQLServer < ActiveRecord::TestCase
       assert SSTestStringDefaultsView.connection.data_source_exists?(SSTestStringDefaultsView.table_name)
     end
 
-    # Doing identity inserts
-
-    it 'be able to do an identity insert' do
-      customer = SSTestCustomersView.new
-      customer.id = 420
-      customer.save!
-      assert SSTestCustomersView.find(420)
-    end
-
     # That have more than 4000 chars for their defintion
 
     it 'cope with null returned for the defintion' do