Ensure small datetime/datetime2 fractionals are properly quoted. Fixes #457.

Author: metaskills

CHANGELOG.md

@@ -1,3 +1,10 @@
+## v4.2.10
+
+#### Fixed
+
+* Ensure small datetime/datetime2 fractionals are properly quoted. Fixes #457.
+
+
 ## v4.2.9
 
 #### Fixed

VERSION

@@ -1 +1 @@
-4.2.9
+4.2.10

lib/active_record/connection_adapters/sqlserver/type/time_value_fractional.rb

@@ -17,7 +17,7 @@ def cast_fractional(value)
 
           def quote_fractional(value)
             seconds = (value.send(fractional_property).to_f / fractional_operator.to_f).round(fractional_scale)
-            seconds.to_s.split('.').last.to(fractional_scale-1)
+            seconds.to_d.to_s.split('.').last.to(fractional_scale-1)
           end
 
           def fractional_property

test/cases/column_test_sqlserver.rb

@@ -354,6 +354,11 @@ def assert_obj_set_and_save(attribute, value)
       obj.datetime2_7.must_equal           Time.utc(9999, 12, 31, 23, 59, 59, Rational(123456800, 1000)), "Nanoseconds were <#{obj.datetime2_7.nsec}> vs <123456800>"
       obj.save!
       obj.reload.datetime2_7.must_equal    Time.utc(9999, 12, 31, 23, 59, 59, Rational(123456800, 1000)), "Nanoseconds were <#{obj.datetime2_7.nsec}> vs <123456800>"
+      # Can save small fraction nanosecond precisoins and return again.
+      obj.datetime2_7 = Time.utc(2008, 6, 21, 13, 30, 0, Rational(15020, 1000))
+      obj.datetime2_7.must_equal           Time.utc(2008, 6, 21, 13, 30, 0, Rational(15000, 1000)), "Nanoseconds were <#{obj.datetime2_7.nsec}> vs <15000>"
+      obj.save!
+      obj.reload.datetime2_7.must_equal    Time.utc(2008, 6, 21, 13, 30, 0, Rational(15000, 1000)), "Nanoseconds were <#{obj.datetime2_7.nsec}> vs <15000>"
       # With other precisions.
       time = Time.utc 9999, 12, 31, 23, 59, 59, Rational(123456789, 1000)
       col = column('datetime2_3')

test/cases/specific_schema_test_sqlserver.rb

@@ -68,6 +68,15 @@ class SpecificSchemaTestSQLServer < ActiveRecord::TestCase
     obj.reload.date.must_be_instance_of Date
   end
 
+  it 'allows datetime2 as timestamps' do
+    SSTestBooking.columns_hash['created_at'].sql_type.must_equal 'datetime2(7)'
+    SSTestBooking.columns_hash['updated_at'].sql_type.must_equal 'datetime2(7)'
+    obj1 = SSTestBooking.new name: 'test1'
+    obj1.save!
+    obj1.created_at.must_be_instance_of Time
+    obj1.updated_at.must_be_instance_of Time
+  end
+
   # Natural primary keys.
 
   it 'work with identity inserts' do

test/models/sqlserver/booking.rb

@@ -0,0 +1,3 @@
+class SSTestBooking < ActiveRecord::Base
+  self.table_name = 'sst_bookings'
+end

test/schema/sqlserver_specific_schema.rb

@@ -37,6 +37,12 @@
 
   # Edge Cases
 
+  create_table 'sst_bookings', force: true do |t|
+    t.string :name
+    t.datetime2 :created_at, null: false
+    t.datetime2 :updated_at, null: false
+  end
+
   create_table 'sst_uuids', force: true, id: :uuid do |t|
     t.string :name
     t.uuid   :other_uuid, default: 'NEWID()'