Merge pull request #149 from ManageIQ/dont_hit_db_on_inspect

Don't hit the database on inspect and run the selects without retry and log blocks.

Author: metaskills

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -176,7 +176,7 @@ class SQLServerAdapter < AbstractAdapter
       DATABASE_VERSION_REGEXP     = /Microsoft SQL Server\s+"?(\d{4}|\w+)"?/
       SUPPORTED_VERSIONS          = [2005,2008,2010,2011].freeze
 
-      attr_reader :database_version, :database_year, :spid
+      attr_reader :database_version, :database_year, :spid, :product_level, :product_version, :edition
 
       cattr_accessor :native_text_database_type, :native_binary_database_type, :native_string_database_type,
                      :log_info_schema_queries, :enable_default_unicode_types, :auto_connect,
@@ -208,6 +208,9 @@ def initialize(logger,config)
                          rescue
                            0
                          end
+        @product_level    = info_schema_query { select_value("SELECT CAST(SERVERPROPERTY('productlevel') AS VARCHAR(128))") }
+        @product_version  = info_schema_query { select_value("SELECT CAST(SERVERPROPERTY('productversion') AS VARCHAR(128))") }
+        @edition          = info_schema_query { select_value("SELECT CAST(SERVERPROPERTY('edition') AS VARCHAR(128))") }
         initialize_dateformatter
         initialize_sqlserver_caches
         use_database
@@ -323,20 +326,8 @@ def version
         self.class::VERSION
       end
 
-      def product_level
-        @product_level ||= info_schema_query { select_value("SELECT CAST(SERVERPROPERTY('productlevel') AS VARCHAR(128))")}
-      end
-      
-      def product_version
-        @product_version ||= info_schema_query { select_value("SELECT CAST(SERVERPROPERTY('productversion') AS VARCHAR(128))")}
-      end
-      
-      def edition
-        @edition ||= info_schema_query { select_value("SELECT CAST(SERVERPROPERTY('edition') AS VARCHAR(128))")}
-      end
-      
       def inspect
-        "#<#{self.class} version: #{version}, year: #{@database_year}, product_level: #{product_level.inspect}, product_version: #{product_version.inspect}, edition: #{edition.inspect}, connection_options: #{@connection_options.inspect}>"
+        "#<#{self.class} version: #{version}, year: #{@database_year}, product_level: #{@product_level.inspect}, product_version: #{@product_version.inspect}, edition: #{@edition.inspect}, connection_options: #{@connection_options.inspect}>"
       end
 
       def auto_connect
@@ -443,7 +434,7 @@ def connect
                           end
                         end
                       end
-        @spid = _raw_select("SELECT @@SPID", :fetch => :rows).first.first
+        @spid             = _raw_select("SELECT @@SPID", :fetch => :rows).first.first
         configure_connection
       rescue
         raise unless @auto_connecting